Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Hash calculation no allocations #8264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Request Hash calculation no allocations #8264

wants to merge 2 commits into from
+6 −3

Conversation

LukaszRozmej
Copy link
Member

Changes

  • Use RecyclableMemoryStream instead of ArrayPoolList to avoid ToArray when computing hash

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej marked this pull request as ready for review February 24, 2025 23:33
MarekM25
MarekM25 reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insane :D

@LukaszRozmej
Copy link
Member Author

insane :D

Nah, normal. You forgot to approve BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 left review comments

@benaadams benaadams Awaiting requested review from benaadams

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukaszRozmej @MarekM25