Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merkle proof data conversion to only remove leading zeros #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: merkle proof data conversion to only remove leading zeros #58

wants to merge 1 commit into from

Conversation

ametel01
Copy link
Collaborator

  • Fix critical security vulnerability in u256_to_be_bytes where all zeros were being removed
  • Update implementation to only remove leading zeros while preserving internal and trailing zeros
  • Add comprehensive unit tests to verify correct byte handling
  • Fixes audit finding regarding Merkle proof verification vulnerability

@ametel01
fix: merkle proof data conversion to only remove leading zeros
7b8d1d9 
- Fix critical security vulnerability in u256_to_be_bytes where all zeros were being removed
- Update implementation to only remove leading zeros while preserving internal and trailing zeros
- Add comprehensive unit tests to verify correct byte handling
- Fixes audit finding regarding Merkle proof verification vulnerability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ametel01