docs: add interface ID source comments and mark ERC20_INTERFACE_ID as arbitrary#62
Open
docs: add interface ID source comments and mark ERC20_INTERFACE_ID as arbitrary#62
Conversation
Collaborator
ametel01
commented
Jan 24, 2025
ametel01
commented
- Added source comments for ERC721 and ERC1155 interface IDs linking to OpenZeppelin implementation
- Added note that ERC20 interface ID is arbitrary and incorrect since ERC20 does not implement introspection on Starknet
- This interface ID should be removed in a future PR since it's not used and could be misleading
- Added source comments for ERC721 and ERC1155 interface IDs linking to OpenZeppelin implementation - Added note that ERC20 interface ID is arbitrary and incorrect since ERC20 does not implement introspection on Starknet - This interface ID should be removed in a future PR since it's not used and could be misleading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.