Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/matrix folding #2

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Feat/matrix folding #2

wants to merge 32 commits into from
+988 −68

Conversation

Fantoni0
Copy link
Collaborator

@Fantoni0 Fantoni0 commented Jan 28, 2025 •
edited
Loading

  • Implements Mova-like matrix folding as described in "Folding and Lookup Arguments for Proving Inference of Deep
    Learning Models"
    • Compatible with Sonobe library.
    • Does not implement any optimization for sparsity yet.
  • Fixes bug in PointVsLIne protocol.

@Fantoni0 Fantoni0 requested review from cupicmarko and NiDimi January 28, 2025 18:25
NiDimi and others added 10 commits January 28, 2025 22:04
@NiDimi
Added evaluations test
32741d4
@NiDimi
left behind
43b3958
@NiDimi
typo
323bd70
@NiDimi
Fixed bug + Added matrix test
70e2f24 
-> Fixed an small issue where we were passing a ci in matrix that wasnt needed
-> Added test for correct re_prime
-> Added tests for mova_matrix variant of ptvsline
@NiDimi
Left behind
81e4ba1
@NiDimi
typo
aba96c5
@Fantoni0
Fix minor bug
8a6ec4e
@NiDimi
added re_prime to the proof
25efde0
@NiDimi
Merge branch 'feat/matrix_folding' into test/ptvsline_h_test
1571378
@NiDimi
CLI fixes
49edfe6
NiDimi and others added 3 commits January 29, 2025 16:14
NiDimi
NiDimi requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@NiDimi NiDimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Also, let me know what you think but we should open an issue about implementing a check check_evaluation for the mova_matrix.

folding-schemes/src/folding/nova/nifs/mova_matrix.rs Outdated Show resolved Hide resolved
folding-schemes/src/folding/nova/nifs/mova_matrix.rs Outdated Show resolved Hide resolved
folding-schemes/src/folding/nova/nifs/mova_matrix.rs Show resolved Hide resolved
folding-schemes/src/folding/nova/nifs/mova_matrix.rs Outdated Show resolved Hide resolved
folding-schemes/src/folding/nova/nifs/mova_matrix.rs Outdated Show resolved Hide resolved
folding-schemes/src/folding/nova/nifs/pointvsline.rs Outdated Show resolved Hide resolved
folding-schemes/src/utils/vec.rs Outdated Show resolved Hide resolved
@Fantoni0 Fantoni0 requested a review from NiDimi January 31, 2025 07:39
NiDimi
NiDimi approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@NiDimi NiDimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiDimi NiDimi NiDimi approved these changes

@cupicmarko cupicmarko Awaiting requested review from cupicmarko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fantoni0 @NiDimi