This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
InferType-changes #903
Draft
InferType-changes #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/sideway/formula/releases) - [Commits](hapijs/formula@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: "@sideway/formula" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This pr is waiting for behaviour tests to be working on the Cairo 1.0 branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve all conflicts from the use of the new InferType class to get node's types. Infer Type and the current way to compute types using e parser over typeString node's property are not compatible and they can't exist together so this branch can only be merged once it's completed the transition.
Remaining errors
Before the transition to Cairo 1, there were 7 behavior tests failing, some of them were caused by hard modifications to the AST that leave it in an inconsistent state that the former parser approach couldn't identify. Those AST modifications have a meaning if we have in mind the big picture and the last state of the transpiration, but in an immediate step it seams like an error. An example of those is the simulation of an
oroperation with a substraction of booleans (assuming false is 0 and true 1). A subtraction of two booleans have no semantic meaning.These errors do not exist's anymore with the transition to
Cairo 1so was decided to go for the transition but with the new version we also lost all testing over the transpiled files. The final state of warp pass some of the behavior test but not all of them and until don't exist a test pool strong like the one forCairo 0it's not advised to merge this changes. The implementation of new features can be stuck by errors related to Infer Type if we merge these changes and could be hard to trace them back to this as a cause.Known errors
safeGetNodeTypewith inferType return a specialized type, some cases were implemented thinking in a generalized type