feat(proxy): add --proxy-domains flag for domain-specific proxying with wildcard support #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maksadbek
commented
Aug 3, 2024
•
maksadbek
commented
- Rename “proxy-internal” to “proxy-target”.
- Rename “proxy-external” to “proxy-bright”.
- Add a new “proxy-domains” flag as an optional flag. It can be accepted when the user is setting either “proxy-target” or “proxy”. It can receive a comma-separated list of domains which will be proxied. Any domain that is not part of the list won’t be proxied. Notes: Support for wildcard is required. If I specify “*.foo.bar” as one of the domains, “a.foo.bar”, “b.foo.bar”, etc. will all be proxied.
- Bright domains will always be proxied when using with the “proxy” flag, without a need to have them explicitly listed as part of the “proxy-domains” list. if the user doesn’t want to proxy bright domains, he should use only "proxy-target"
maksadbek
commented
Aug 3, 2024
denis-maiorov-brightsec
requested changes
Aug 5, 2024
derevnjuk
reviewed
Aug 5, 2024
maksadbek
changed the title
maksadbek
force-pushed
the
bypass-proxy-with-domain-settings
branch
from
450eb4c
to
9f90dde
Compare
maksadbek
force-pushed
the
bypass-proxy-with-domain-settings
branch
from
47080e2
to
efc4df6
Compare
denis-maiorov-brightsec
requested changes
Aug 6, 2024
Co-authored-by: denis-maiorov-brightsec <[email protected]>
maksadbek
changed the title
denis-maiorov-brightsec
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.