fix(repeater): introduce max-body-size to avoid breaking socket connection on large responses #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction on large responses Introduce max-body-size limit, so large reponse bodies will be truncated/omitted, so it wont break the socket connection. PAP-1125 #code-review
…ction on large responses Introduce max-body-size limit, so large reponse bodies will be truncated/omitted, so it wont break the socket connection. PAP-1125 #code-review
denis-maiorov-brightsec
requested changes
Aug 8, 2024
added 2 commits
August 8, 2024 16:44
…ction on large responses Introduce max-body-size limit, so large reponse bodies will be truncated/omitted, so it wont break the socket connection. PAP-1125 #code-review
|
@denis-maiorov-brightsec I remember now that Avishai also asked to write an error-log in case truncation/omission happens for white-listed mime-types, so I will still need to make a change to the code |
denis-maiorov-brightsec
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a maxBodySize limit to manage large response bodies, truncating or omitting them as necessary to prevent socket connection disruptions