fix(oas): adjust according to code review

closes #210
NeuraLegion · Sep 21, 2023 · f9592b5 · f9592b5
1 parent 82b8c61
commit f9592b5
Show file tree

Hide file tree

Showing 7 changed files with 1,914 additions and 1,904 deletions.
diff --git a/packages/oas/src/converter/parts/headers/HeadersConverter.ts b/packages/oas/src/converter/parts/headers/HeadersConverter.ts
@@ -14,17 +14,22 @@ export abstract class HeadersConverter<T extends OpenAPI.Document>
   implements SubConverter<Header[]>
 {
   private readonly CONTENT_TYPE_METHODS = ['post', 'put', 'patch', 'delete'];
+  private readonly CONTENT_TYPE_HEADER = 'content-type';
 
   protected constructor(
     private readonly spec: T,
     private readonly sampler: Sampler
   ) {}
 
   protected abstract createContentTypeHeaders(
-    pathObj: OperationObject
+    pathObj: OperationObject,
+    header?: Header
   ): Header[];
 
-  protected abstract createAcceptHeaders(pathObj: OperationObject): Header[];
+  protected abstract createAcceptHeaders(
+    pathObj: OperationObject,
+    header?: Header
+  ): Header[];
 
   protected abstract convertHeaderParam(
     headerParam: LocationParam<ParameterObject>
@@ -34,7 +39,12 @@ export abstract class HeadersConverter<T extends OpenAPI.Document>
     const headers: Header[] = [];
     const pathObj = getOperation(this.spec, path, method);
 
-    if (this.CONTENT_TYPE_METHODS.includes(method.toLowerCase())) {
+    if (
+      this.CONTENT_TYPE_METHODS.includes(method.toLowerCase()) &&
+      !headers.find(
+        (header) => header.name.toLowerCase() === this.CONTENT_TYPE_HEADER
+      )
+    ) {
       headers.push(...this.createContentTypeHeaders(pathObj));
     }