Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oas): combine PathItemObject and OperationObject parameters #249

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Aug 21, 2024

fixes #248

@ostridm ostridm added the Type: bug Something isn't working. label Aug 21, 2024
@ostridm ostridm self-assigned this Aug 21, 2024
Copy link

codeclimate bot commented Aug 21, 2024

Code Climate has analyzed commit f95f1f2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.1% (-0.1% change).

View more on Code Climate.

@ostridm ostridm requested a review from derevnjuk August 21, 2024 15:24
@ostridm ostridm enabled auto-merge (squash) August 21, 2024 15:32
packages/oas/src/utils/params.ts Outdated Show resolved Hide resolved
packages/oas/src/utils/params.ts Outdated Show resolved Hide resolved
packages/oas/src/utils/params.ts Outdated Show resolved Hide resolved
@ostridm ostridm requested a review from derevnjuk August 22, 2024 07:56
@ostridm ostridm requested a review from derevnjuk August 22, 2024 09:11
@ostridm ostridm merged commit ce551fe into master Aug 22, 2024
5 checks passed
@ostridm ostridm deleted the fix_#248/combine-operation-and-path-item-parameters branch August 22, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAS: Converter does not pick up the PathItemObject parameters
2 participants