[WIP] Add warning if annotations would shadow channelindex parameters #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @JuliaSprenger! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Noted. |
|
@JuliaSprenger : this can be close no ? |
|
This is outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the annotations used for generating ChannelIndex objects might overlap with the default parameters. This adds a test to prevent unintended shadowing of the parameters and warns an overlap is detected.
For an implementation of a test I wait for @achilleas-k implementation of another test which compares the writing of the non-raw NixIO to the raw NixIO implementation. Extending this one to also cover parameter overlaps should be straight forward then.
@samuelgarcia: If you see an easier way to implement a test for this, feel free to continue working based on this PR.