Update dashboard cog for d.py 2.0 #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrustyJAID
commented
Oct 24, 2022
Comment on lines
-354
to
-362
| region = getattr(guild.region, "name", guild.region) | ||
| parts = region.split("_") | ||
| for i, p in enumerate(parts): | ||
| if p in ["eu", "us", "vip"]: | ||
| parts[i] = p.upper() | ||
| else: | ||
| parts[i] = p.title() | ||
| region = " ".join(parts) | ||
|
|
There was a problem hiding this comment.
Region is no longer part of the guild object. Maybe replace region with the servers locale?
TrustyJAID
commented
Oct 24, 2022
Comment on lines
+16
to
+19
| @commands.group(name="dashboard") | ||
| async def dashboard(self, ctx: commands.Context): | ||
| """Group command for controlling the web dashboard for Red.""" | ||
| pass |
There was a problem hiding this comment.
This change is because the old method of importing the top level command object caused an unexpected CTX to be required for all commands preventing Red's autohelp from functioning and all commands for that matter. This method maintains the expected behavior of one top level command shared between all files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making this PR as a way to track all the things I have had to change already to make the dashboard cog work on d.py 2.0. Feel free to ignore the PR or do something different.