SerialImp.c:RXTXPort(open) - avoid noop fcntl() and pointless assignments #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyanpalauzov
force-pushed
the
rxtxport_open_pointless_assignments
branch
from
eb76c8b to
d003d07
Compare
dilyanpalauzov
changed the title
dilyanpalauzov
pushed a commit
to dilyanpalauzov/nrjavaserial
that referenced
this pull request
Nov 5, 2025
…ents NeuronRobotics#261 The file is already opened with O_RDWR | O_NOCTTY | O_NONBLOCK. * O_RDWR cannot be changed on linux with F_SETFL - https://man7.org/linux/man-pages/man2/F_GETFL.2const.html * The last page lists explicitly what can be changed by F_SETFL and O_NOCTTY is not mentioned. * O_NONBLOCK is already set when opening the file. * FD_CLOEXEC is supposed to be set with F_SETFD - https://man7.org/linux/man-pages/man2/F_SETFD.2const.html * Remove pointless assignments.
…ents The file is already opened with O_RDWR | O_NOCTTY | O_NONBLOCK. * O_RDWR cannot be changed on linux with F_SETFL - https://man7.org/linux/man-pages/man2/F_GETFL.2const.html * The last page lists explicitly what can be changed by F_SETFL and O_NOCTTY is not mentioned. * O_NONBLOCK is already set when opening the file * FD_CLOEXEC is supposed to be set with F_SETFD - https://man7.org/linux/man-pages/man2/F_SETFD.2const.html * remove pointless assignments
dilyanpalauzov
force-pushed
the
rxtxport_open_pointless_assignments
branch
from
d003d07 to
2dbd902
Compare
dilyanpalauzov
changed the title
dilyanpalauzov
pushed a commit
to dilyanpalauzov/nrjavaserial
that referenced
this pull request
Nov 7, 2025
…ents NeuronRobotics#261 The file is already opened with O_RDWR | O_NOCTTY | O_NONBLOCK. * O_RDWR cannot be changed on linux with F_SETFL - https://man7.org/linux/man-pages/man2/F_GETFL.2const.html * The last page lists explicitly what can be changed by F_SETFL and O_NOCTTY is not mentioned. * O_NONBLOCK is already set when opening the file. * FD_CLOEXEC is supposed to be set with F_SETFD - https://man7.org/linux/man-pages/man2/F_SETFD.2const.html * Remove pointless assignments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file is already opened with O_RDWR | O_NOCTTY | O_NONBLOCK.
O_RDWR cannot be changed on linux with F_SETFL - https://man7.org/linux/man-pages/man2/F_GETFL.2const.html
The last page lists explicitly what can be changed by F_SETFL and O_NOCTTY is not mentioned.
O_NONBLOCK is already set when opening the file
FD_CLOEXEC is supposed to be set with F_SETFD - https://man7.org/linux/man-pages/man2/F_SETFD.2const.html
remove pointless assignments