feat: add strategy selector with cards, comparison table, and confirm…#58
Open
TomikeDS wants to merge 6 commits intoNeurowealth:mainfrom
Open
feat: add strategy selector with cards, comparison table, and confirm…#58TomikeDS wants to merge 6 commits intoNeurowealth:mainfrom
TomikeDS wants to merge 6 commits intoNeurowealth:mainfrom
Conversation
…ation UX Implements the full strategy selection flow at /dashboard/strategy: - Three equal-weight cards (Conservative, Balanced, Growth) with selected state using 2px primary border + sky-500/8 background tint per spec - Risk badges: Conservative → accent (sky-400), Balanced → warning (amber-500), Growth → danger (red-500) - Card content: title, APY range, risk badge, ≤140-char description, primary CTA - Comparison table (APY, risk, rebalance, liquidity, drawdown, horizon) with horizontal scroll on mobile and sticky header on desktop - Confirmation modal: from→to summary, APY/risk preview, cancel/confirm with loading state, error banner, and Escape-to-dismiss - Success banner with aria-live region after preference is saved - Loading skeleton while initial preference is fetched - GET /api/strategy + PUT /api/strategy endpoints; tries real backend via NEUROWEALTH_API_BASE_URL, falls back to in-memory mock + localStorage - Passes lint, tsc --noEmit, and npm run build (frontend-ci.yml)
|
@TomikeDS Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
kindly fix your conflict and i'll merge |
Author
|
@Abidoyesimze conflict resolved |
Contributor
|
Kindly fix the failing CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
border-2 border-sky-500 bg-sky-500/8per spec. Each card shows title, APY range, risk badge, ≤140-char description, and a primary action button.bg-sky-400/15 text-sky-400(accent), Balancedbg-amber-500/15 text-amber-500(warning), Growthbg-red-500/15 text-red-500(danger).theadon desktop. Active strategy column is highlighted.aria-live="polite"region confirms the save and explains the rebalance cycle.GET /api/strategyandPUT /api/strategy. Forwards toNEUROWEALTH_API_BASE_URL/strategy/preferencewhen set; falls back to an in-memory mock that is also mirrored tolocalStoragefor cross-refresh persistence./dashboard/strategywrapped inProtectedRoute+Suspense.Design spec compliance
grid-cols-3withflex-colcardsborder-2 border-sky-500 bg-sky-500/8bg-sky-400/15 text-sky-400bg-amber-500/15 text-amber-500bg-red-500/15 text-red-500overflow-x-autowithmin-w-[480px]tablesticky top-0 z-10ontheadcloses #32
closes #33