π§ μΉ΄μΉ΄μ€ν‘ URL νλμ½λ© μμ - #115
Merged
Merged
Conversation
WalkthroughKakao OAuth2 ν΄λΌμ΄μΈνΈμ 리λ€μ΄λ νΈ URI μ€μ μ΄ κ³ μ λ URLμμ Changes
Possibly related PRs
πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| spring.security.oauth2.client.registration.kakao.client-secret=${KAKAO_CLIENT_SECRET} | ||
| spring.security.oauth2.client.registration.kakao.client-authentication-method=client_secret_post | ||
| spring.security.oauth2.client.registration.kakao.redirect-uri=https://api.likelionnews.click/login/oauth2/code/kakao | ||
| spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL}/login/oauth2/code/kakao |
There was a problem hiding this comment.
π‘ Verification agent
β Verification inconclusive
BASE_URL λ―Έμ€μ β§μ¬λμ μ€λ³΅ μ λ°νμ μ€λ₯ κ°λ₯μ± β κΈ°λ³Έκ° λ° μ κ·ν κ³ λ € νμ
redirect-uri κ°μ ${BASE_URL} νλ μ΄μ€νλλ₯Ό μ§μ μ½μ
νλ©΄
BASE_URLμ΄ μ€μ λμ§ μμ νλ‘νμΌμμ Spring λΆν λ¨κ³μμ placeholder not resolved μμΈκ° λ°μν μ μκ³ ,BASE_URLμ/λ‘ λλλ κ°μ΄ λ€μ΄μ€λ©΄//login/oauth2...ννλ‘ μ€λ³΅ μ¬λμκ° μμ±λ©λλ€.
λ€μκ³Ό κ°μ΄ κΈ°λ³Έκ°κ³Ό νν μ¬λμ μ κ±°λ₯Ό ν¬ν¨ν ννμμ κΆμ₯ν©λλ€.
-spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL}/login/oauth2/code/kakao
+spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL:https://api.likelionnews.click}/login/oauth2/code/kakaoλλ BASE_URL κ°μ μ€μ ν λ νν μ¬λμλ₯Ό μ κ±°νλλ‘ λ¬ΈμννμΈμ.
μ μ© μ /ν νκ²½λ³ λΆν
ν
μ€νΈλ₯Ό ν λ² λ νμΈν΄ μ£ΌμΈμ.
BASE_URL λ―Έμ€μ λ° μ¬λμ μ€λ³΅ λ¬Έμ β κΈ°λ³Έκ° μ€μ κ³Ό μ κ·ν νμ
λ¬Έμ μμ½:
BASE_URLμ΄ μ€μ λμ§ μμ νλ‘νμΌμμ Spring λΆν μ placeholder not resolved μμΈ λ°μ κ°λ₯BASE_URLλμ μ¬λμ(/)κ° ν¬ν¨λλ©΄//login/oauth2β¦ννλ‘ μ€λ³΅ μ¬λμ μμ±
κΆμ₯ μμ μ:
-spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL}/login/oauth2/code/kakao
+spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL:https://api.likelionnews.click}/login/oauth2/code/kakaoλλ,
BASE_URLκ°μ μ λ ₯ν λ νν μ¬λμλ₯Ό μ κ±°νλλ‘ λ¬Έμν- λ³κ²½ μ /ν νκ²½λ³ λΆν ν μ€νΈ μν
π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL}/login/oauth2/code/kakao | |
| # SpringBoot/src/main/resources/application.properties | |
| spring.security.oauth2.client.registration.kakao.redirect-uri=${BASE_URL:https://api.likelionnews.click}/login/oauth2/code/kakao |
π€ Prompt for AI Agents
In SpringBoot/src/main/resources/application.properties at line 47, the BASE_URL
placeholder may cause unresolved placeholder exceptions if not set, and trailing
slashes in BASE_URL can lead to double slashes in the redirect URI. To fix this,
provide a default value for BASE_URL using the syntax
${BASE_URL:http://default.url} to avoid unresolved placeholders, and ensure the
redirect-uri concatenation removes any trailing slash from BASE_URL to prevent
double slashes. Alternatively, document that BASE_URL should not have a trailing
slash and test application startup across environments before and after changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.env νμΌ
BASE_URL=https://api.likelionnews.click μΆκ°
Summary by CodeRabbit
BASE_URL)λ₯Ό μ¬μ©νμ¬ λμ μΌλ‘ μ€μ λλλ‘ λ³κ²½λμμ΅λλ€.