🐛 [버그 수정] & ⚡️[성능 향상] : Setting 객체 저장 시 영속성 문제 해결 & 페이지네이션 반환 DTO 수정

[moonjun1]

🐛 [버그 수정] & ⚡️[성능 향상] : Setting 객체 저장 시 영속성 문제 해결 & 페이지네이션 반환 DTO 수정

Summary by CodeRabbit

• Chores

  • Docker 볼륨 보존 및 로그 관리가 개선되어 배포 시 데이터 손실 위험이 줄어들고, 서비스별 로그 파일 크기 및 회전 설정이 추가되었습니다.
  • SpringBoot 서비스에 BASE_URL, BACKEND_DOMAIN, FRONTEND_DOMAIN 환경 변수가 추가되었습니다.
  • Redis 및 Elasticsearch 데이터와 플러그인 보존을 위한 볼륨 설정이 강화되었습니다.

• Style

  • 코드 내 불필요한 공백이 일부 추가되어 가독성이 소폭 개선되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경사항은 Docker 볼륨 보존 및 서비스 로깅 설정 강화, 환경 변수 추가, 그리고 배포 워크플로우에서 Elasticsearch 플러그인 및 인덱스 상태 검증, Redis/MySQL 연결 확인 등 배포 안정성 및 가시성을 높이기 위한 업데이트를 포함합니다. 코드 파일에는 공백 추가만 이루어졌습니다.

Changes

파일/경로 그룹	변경 요약
.github/workflows/deploy-prod.yml	배포 워크플로우에서 Docker 볼륨 보존, Elasticsearch 플러그인/인덱스 검증, 서비스 상태 점검 강화
docker-compose.yml	서비스별 로깅 설정 추가, 환경 변수 및 네임드 볼륨 추가, 불필요 주석 제거
SpringBoot/src/main/java/Baemin/News_Deliver/Global/JWT/JwtTokenProvider.java	validateToken 메서드 전후에 공백 줄 추가
SpringBoot/src/main/java/Baemin/News_Deliver/Global/OAuth2/OAuth2LoginSuccessHandler.java	createRedirectUrl 내부에 공백 줄 추가

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub Actions
    participant Remote Server
    participant Docker
    participant Elasticsearch
    participant Redis
    participant MySQL

    Developer->>GitHub Actions: Push/Deploy Trigger
    GitHub Actions->>Remote Server: SSH & 실행
    Remote Server->>Docker: 중지 컨테이너/이미지/네트워크 정리 (볼륨 보존)
    Remote Server->>Docker: 필요 볼륨 생성 및 존재 확인
    Remote Server->>Docker: 컨테이너 시작 (기존 볼륨 재사용)
    Remote Server->>Elasticsearch: 플러그인(analysis-nori) 확인/설치/재시작
    Remote Server->>Elasticsearch: 클러스터 상태/인덱스/플러그인 확인
    Remote Server->>MySQL: 연결성 확인(ping)
    Remote Server->>Redis: 연결성 확인(ping)
    Remote Server->>SpringBoot: HotTopic API Health Check
    Remote Server->>SpringBoot: HTTPS Health Check (HotTopic 포함)
    Remote Server->>Developer: 배포 요약 및 상태 보고

Loading

Estimated code review effort

3 (~40분)

Suggested reviewers

• wjkim9

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3446f08 and 7c607f5.

📒 Files selected for processing (4)

• .github/workflows/deploy-prod.yml (8 hunks)
• SpringBoot/src/main/java/Baemin/News_Deliver/Global/JWT/JwtTokenProvider.java (1 hunks)
• SpringBoot/src/main/java/Baemin/News_Deliver/Global/OAuth2/OAuth2LoginSuccessHandler.java (1 hunks)
• docker-compose.yml (11 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.