-
Notifications
You must be signed in to change notification settings - Fork 694
fix: allow warm up with system prompt #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes warm-up functionality to allow warm-up requests that include a system prompt. The change ensures that models can be properly warmed up even when a system prompt is provided.
- Modified warm-up logic to accept requests with only a system prompt message
- Replaced default struct tags with a constructor function for better default value management
- Updated CLI to include system prompt in warm-up requests when specified
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
runner/server/handler/completion.go | Refactored default values from struct tags to constructor function and updated warm-up condition to allow system prompt |
runner/cmd/nexa-cli/run.go | Added system prompt to warm-up request and included missing CLI flag for thinking mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.