Skip to content

Conversation

RemiliaForever
Copy link
Collaborator

No description provided.

@RemiliaForever RemiliaForever changed the title fix: allow warm up with system promp fix: allow warm up with system prompt Oct 3, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes warm-up functionality to allow warm-up requests that include a system prompt. The change ensures that models can be properly warmed up even when a system prompt is provided.

  • Modified warm-up logic to accept requests with only a system prompt message
  • Replaced default struct tags with a constructor function for better default value management
  • Updated CLI to include system prompt in warm-up requests when specified

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
runner/server/handler/completion.go Refactored default values from struct tags to constructor function and updated warm-up condition to allow system prompt
runner/cmd/nexa-cli/run.go Added system prompt to warm-up request and included missing CLI flag for thinking mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RemiliaForever RemiliaForever requested a review from Copilot October 3, 2025 12:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant