Merged
Conversation
portableDD
approved these changes
Aug 22, 2025
Contributor
portableDD
left a comment
There was a problem hiding this comment.
Good Work, Fix conflict and we are good to go
Contributor
Author
|
@portableDD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Notification UI
📋 Description
I built the notification dropdown according the figma design provided. I also set it up for data fetching using the backend API_URL.
🛠 Changes Implemented
NotificationDropdown.tsxand wired it up with the bell icon on the Navbar.api/notificationService.tsfile and addedgetNotification,markAsReadandmarkAllAsReadutility functions.useNotificationsanduseMarkAllAsReadhooks.✅ How to Test
feat/notificationbranch.npm installandnpm run devto start the local dev environment./dashboardand click on the bell icon to see the notifcation dropdown.🔍 Screenshots (if applicable)
Desktop Screen
Screencast from 2025-08-22 18-44-54.webm
Mobile Screen
Screencast from 2025-08-22 18-47-00.webm
🚀 Checklist
🔗 Related Issues
Additional Information
Currently the dropdown renders a dummy data as notifications. This is because the getNotifications functions requires a userId which is gotten when the user signs in. Apart from that, the utility functions are available and ready to use. All one has to do is just to pass the userId into the hooks and loop over the data variable returned by tanstack query.
@portableDD
Please review. Thanks 🙏.