Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* theme 클래스에 이미지 관련 데이터 필드 추가 * 배경설정 화면으로 theme 데이터 가지고 들어가도록 수정 * 이미지 처리
tak8997
commented
Jan 24, 2025
presentation/src/main/java/com/nextroom/nextroom/presentation/ui/adminmain/ThemeListFragment.kt
Outdated
Show resolved
Hide resolved
data/src/main/java/com/nextroom/nextroom/data/datasource/SettingDataSource.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nextroom/nextroom/presentation/ui/adminmain/BannerAdapter.kt
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| SubscribeStatus.Subscribed -> llBanner.isVisible = false | ||
| SubscribeStatus.Subscribed -> rvBanner.isVisible = false |
There was a problem hiding this comment.
[수정 요청]
이전 버전에 있던 구독 유도 배너는
구독 상태에 따라 visible이 바뀌는 게 맞는데
이번에 리뉴얼 된 배너는 구독상태에 따라 분기를 타지 않습니당!
그냥 공지사항, 새로운 기능 알림 같은 용도로 쓰는거 라고 봐주면 돼
* 배경화면 커스텀 정보 converter 추가
tak8997
force-pushed
the
feature/배경화면_커스텀_1차
branch
from
b122fa4 to
a4c5e48
Compare
| listOf( | ||
| Benefit( | ||
| title = "구독혜택 1.", | ||
| desc = "힌트와 이미지를 함께 제공", |
...rc/main/java/com/nextroom/nextroom/presentation/ui/SubscriptionPaymentBottomSheetFragment.kt
Outdated
Show resolved
Hide resolved
data/src/main/java/com/nextroom/nextroom/data/network/response/ThemeDto.kt
Show resolved
Hide resolved
data/src/main/java/com/nextroom/nextroom/data/network/response/ThemeDto.kt
Show resolved
Hide resolved
* 다시 화면에 진입했을때 관련 최신 설정값을 받아오도록 수정
* 깜빡이는 현상이 있어서 디폴트 안보여주도록 수정
* 다이얼로그를 호출한 화면에서 popbackstack을 연속으로 호출하려면 dismiss가 아닌 popbackstack을 호출해야함.
* 라이프싸이클 인자로 전달 * 리스너 해제
* 라이프싸이클에 따라 다시 그려져야 함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배경화면 커스텀 작업.
마지막 커밋은 force push로 바꿀예정