Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/255 선물 등록하기 #268

Merged
merged 17 commits into from
Jul 28, 2024
Merged

Feature/255 선물 등록하기 #268

merged 17 commits into from
Jul 28, 2024

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Jul 24, 2024

Issue

작업 내용

  • 선물 받기 동적 링크로 들어올 경우 딥링크에서 gift uuid 뽑는다.
  • 비로그인일 경우 로그인 화면으로 안내한다.
  • 로그인 직후 다시 선물 등록 팝업을 띄워준다.
  • 이미 로그인 상태일 경우 선물 등록 팝업을 띄워준다.
  • 근데 자기가 선물한 거면 니 선물 니가 받을 거냐고 물어본다.
  • 로그인 전후로 선물 정보를 유지하기 위해 메모리에 uuid를 저장하는데, 취소 등의 행동을 할 경우 uuid를 지워준다.
KakaoTalk_20240724_234545521.mp4

@HamBP HamBP added the feat 새로운 기능 label Jul 24, 2024
@HamBP HamBP added this to the gift milestone Jul 24, 2024
@HamBP HamBP self-assigned this Jul 24, 2024
@HamBP HamBP marked this pull request as draft July 24, 2024 18:22
Copy link

github-actions bot commented Jul 24, 2024

Test Results

 9 files   9 suites   0s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit a01afd1.

♻️ This comment has been updated with latest results.

@HamBP HamBP marked this pull request as ready for review July 25, 2024 17:29
@HamBP HamBP requested a review from mangbaam July 25, 2024 17:55
intent.action?.let { _ ->
val deepLink = intent.data.toString()
intent.data = null
val regex = "^https://app.boolti.in/gift/([\\w-])+$".toRegex()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 스키마 형태가 바뀌거나 쿼리 파람이 추가되면 처리를 못하거나 giftUuid 를 잘못 꺼내올 수 있어서 방어로직을 추가하거나 확실히 인지하고 있는 게 좋을 듯

안 그러면 문제가 발생했을 때 원인을 찾기 힘들 수도 있을 거 같다는 생각이 드네

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흐음... 방어로직 추천 받습니다
(어떻게 짜야할 지 모르겠...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun main() {
    val regex = Regex("^https://app\\.boolti\\.in/gift/([^?]+)")
    val url1 = "https://app.boolti.in/gift/abc123"
    val url2 = "https://app.boolti.in/gift/abc123?name=\"booti\"&age=18"

    val match1 = regex.find(url1)
    val match2 = regex.find(url2)

    match1?.let {
        println(it.groupValues[1]) // Output: abc123
    }

    match2?.let {
        println(it.groupValues[1]) // Output: abc123
    }
}

지피티한테 위임했어

@HamBP
Copy link
Member Author

HamBP commented Jul 28, 2024

어프루브 되었기 때문에 이슈 만들어 놓고 일단 머지합니다
#271

@HamBP HamBP merged commit 9427654 into develop Jul 28, 2024
2 checks passed
@HamBP HamBP deleted the feature/255 branch September 16, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[선물하기] 선물 등록 flow
2 participants