-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/255 선물 등록하기 #268
Feature/255 선물 등록하기 #268
Conversation
Test Results 9 files 9 suites 0s ⏱️ Results for commit a01afd1. ♻️ This comment has been updated with latest results. |
data/src/main/java/com/nexters/boolti/data/network/response/GiftResponse.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/component/BTDialog.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/component/BTDialog.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/home/GiftDialog.kt
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/home/HomeScreen.kt
Show resolved
Hide resolved
intent.action?.let { _ -> | ||
val deepLink = intent.data.toString() | ||
intent.data = null | ||
val regex = "^https://app.boolti.in/gift/([\\w-])+$".toRegex() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 스키마 형태가 바뀌거나 쿼리 파람이 추가되면 처리를 못하거나 giftUuid 를 잘못 꺼내올 수 있어서 방어로직을 추가하거나 확실히 인지하고 있는 게 좋을 듯
안 그러면 문제가 발생했을 때 원인을 찾기 힘들 수도 있을 거 같다는 생각이 드네
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흐음... 방어로직 추천 받습니다
(어떻게 짜야할 지 모르겠...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fun main() {
val regex = Regex("^https://app\\.boolti\\.in/gift/([^?]+)")
val url1 = "https://app.boolti.in/gift/abc123"
val url2 = "https://app.boolti.in/gift/abc123?name=\"booti\"&age=18"
val match1 = regex.find(url1)
val match2 = regex.find(url2)
match1?.let {
println(it.groupValues[1]) // Output: abc123
}
match2?.let {
println(it.groupValues[1]) // Output: abc123
}
}
지피티한테 위임했어
어프루브 되었기 때문에 이슈 만들어 놓고 일단 머지합니다 |
Issue
작업 내용
KakaoTalk_20240724_234545521.mp4