[CAT-172] 툴팁 구현 #19
Merged
[CAT-172] 툴팁 구현 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jihyun247
previously approved these changes
Aug 9, 2024
Comment on lines
+17
to
+20
| .preference( | ||
| key: FrameMeasurePreferenceKey.self, | ||
| value: [identifier: geometry.frame(in: .global)] | ||
| ) |
There was a problem hiding this comment.
요것은 툴팁의 위치를 정하기 위해 상위뷰(데모앱 버튼)의 크기를 알기 위한 Preference 키인가욥 ?
이것을 이용해서 툴팁 위치를 정하는게 tooltipDestination이고 ? ?
There was a problem hiding this comment.
맞아맞아 툴팁의 타겟이 되는 View의 위치(CGPoint)와 크기(CGSize)를 받아서 tooltipDestination이 TooltipView의 위치를 정해주는거야
There was a problem hiding this comment.
그리고 툴팁의 타겟에 바로 overlay하지 않고 tooltipDestination을 써서 최상위뷰에서 overlay하는 이유는 dim과 같이 전체 영역을 덮어야 하는 경우를 고려하기 위해서이고!
Comment on lines
+53
to
+56
| ExcludeRoundedRectMask( | ||
| excludedRect: position, | ||
| cornerRadius: content.targetCornerRadius ?? .zero | ||
| ) |
There was a problem hiding this comment.
오 ... 프리퍼런스키로 받은 지오메트리가 지오딤을 해줄 땐 버튼은 제외해주기 위해 쓰이기도 하는구나
There was a problem hiding this comment.
그치 대신에 여기서 아쉬운점은 위치와 영역은 알 수 있어서 문제 없이 마스킹해줬지만 cornerRadius는 별도로 지정해줘야한다는거지 ㅠ
|
버튼 및 폰트 개선 작업 추가 기존 코드는 변경 필요없음 |
devMinseok
force-pushed
the
feature/CAT-172
branch
from
279d483 to
b6e0413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
무엇에 관한 PR 인가요? 🙋
어떤 것을 작업하셨나요? 🛠
🌱 PR Point
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-09.at.03.27.21.mp4