Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-176] Onboarding paging뷰 ui 및 기능구현 #25

Merged
merged 11 commits into from
Aug 15, 2024

Conversation

Jihyun247
Copy link
Collaborator

@Jihyun247 Jihyun247 commented Aug 13, 2024

[CAT-176] FEAT : Onboarding paging뷰 ui 및 기능구현

화면녹화

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-14.at.06.07.59.mp4

무엇에 관한 PR 인가요? 🙋

Onboarding paging뷰

어떤 것을 작업하셨나요? 🛠

탭바로 구현했습니다

  • dragging infinite carousel
  • user getsture가 없을 땐 timer를 통한 자동 infinite carousel

🌱 PR Point

  • ScrollView로 구현하려다가 uiScrollDelegate를 쓰니까 끝도 없어져서 다시 탭바로 넘어왔슴다. RandomAccessCollection의 이점에 대해서는 더 공부해봐야할 것 같아요. 아시는 것 있으면 정보 부탁드림다. 우선은 인덱스를 계속 이리저리 옮겨다녀야해서 써보면 좋을까 싶어서 써봤어요

@Jihyun247 Jihyun247 added the enhancement New feature or request label Aug 13, 2024
@Jihyun247 Jihyun247 requested a review from devMinseok August 13, 2024 20:49
@Jihyun247 Jihyun247 self-assigned this Aug 13, 2024
Copy link

linear bot commented Aug 13, 2024

devMinseok
devMinseok previously approved these changes Aug 15, 2024
Copy link
Member

@devMinseok devMinseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어! 👏

@Jihyun247 Jihyun247 merged commit 205135d into develop Aug 15, 2024
1 check passed
@Jihyun247 Jihyun247 deleted the feature/CAT-176 branch August 15, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants