Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-192] 홈 기본 UI 구성 #26

Merged
merged 16 commits into from
Aug 16, 2024
Merged

[CAT-192] 홈 기본 UI 구성 #26

merged 16 commits into from
Aug 16, 2024

Conversation

devMinseok
Copy link
Member

@devMinseok devMinseok commented Aug 15, 2024

어떤 것을 작업하셨나요? 🛠

  • 홈화면 관련 UI만 먼저 개발
    • 서비스 가이드
    • 카테고리 선택
    • 시간 선택

🌱 PR Point

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-16.at.08.33.09.mp4

@devMinseok devMinseok added the enhancement New feature or request label Aug 15, 2024
@devMinseok devMinseok requested a review from Jihyun247 August 15, 2024 23:31
@devMinseok devMinseok self-assigned this Aug 15, 2024
Copy link

linear bot commented Aug 15, 2024

Jihyun247
Jihyun247 previously approved these changes Aug 16, 2024
Copy link
Collaborator

@Jihyun247 Jihyun247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

휠피커 구현 부분 잘봤슴니다... 고생 많았어 !!!

Comment on lines +11 to +16
extension View {
public func onLoad(perform action: (() -> Void)? = nil) -> some View {
modifier(ViewDidLoadModifier(perform: action))
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것은 어떤 역할을 하는거야 ?? onAppear과 다르게 onLoad를 둔 이유 ? ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 코드 보면 알겠지만 viewDidLoad와 같은 역할을 하려고 만든거야

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core에서 didLoad 플래그를 둬도 되긴 하는데 매번 해주는게 불편해서

@devMinseok devMinseok merged commit 2913a90 into develop Aug 16, 2024
1 check passed
@devMinseok devMinseok deleted the feature/CAT-192 branch August 16, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants