[CAT-207] 온보딩 - 고양이 선택하기 뷰 UI및 기능 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devMinseok
requested changes
Aug 16, 2024
Projects/Feature/OnboardingFeature/Sources/Onboarding/OnboardingItem.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/OnboardingFeature/Sources/SelectCat/CatFactory.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/OnboardingFeature/Sources/SelectCat/SelectCatCore.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/OnboardingFeature/Sources/SelectCat/SelectCatView.swift
Outdated
Show resolved
Hide resolved
오잉 아니 !! 이번 이슈에서 make module 로 레이어 지정하고, 모듈 이름 지정해서 UserService 만들어줬어 ! 왜염 ? |
|
아아 이거 원래 스캐폴딩할때 파일헤더가 자동으로 붙어야하는데 UserService에 Project.swift보니까 파일 헤더가 없길래 혹시나해서! |
devMinseok
previously approved these changes
Aug 16, 2024
| @@ -60,7 +60,7 @@ public struct SplashCore { | |||
|
|
|||
| extension SplashCore { | |||
| private func checkDeviceIDExist() -> Effect<Action> { | |||
| let deviceID = keychainClient.read(key: KeychainKeys.deviceID.rawValue) ?? getDeviceUUID() | |||
| let deviceID = keychainClient.read(key: "mohanyang_keychain_device_id") ?? getDeviceUUID() | |||
| @@ -81,7 +81,7 @@ extension SplashCore { | |||
|
|
|||
| private func getDeviceUUID() -> String { | |||
| guard let uuid = UIDevice.current.identifierForVendor?.uuidString, | |||
| keychainClient.create(key: KeychainKeys.deviceID.rawValue, data: uuid) else { | |||
| keychainClient.create(key: "mohanyang_keychain_device_id", data: uuid) else { | |||
There was a problem hiding this comment.
홀리몰리 gpt다 감삼다 항상 맘이 급하면 한번에 제대로 되는것이없네
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CAT-207] 온보딩 - 고양이 선택하기 뷰 UI및 기능
무엇에 관한 PR 인가요? 🙋
온보딩 - 고양이 선택하기 뷰 UI및 기능
어떤 것을 작업하셨나요? 🛠
🌱 PR Point