Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-235] Request, Response log #34

Merged
merged 2 commits into from
Aug 17, 2024
Merged

[CAT-235] Request, Response log #34

merged 2 commits into from
Aug 17, 2024

Conversation

Jihyun247
Copy link
Collaborator

@Jihyun247 Jihyun247 commented Aug 17, 2024

[CAT-235] Request, Response log

무엇에 관한 PR 인가요? 🙋

Request, Response log 이쁘게 찍히도록 만들었습니다
스크린샷 2024-08-17 오후 10 52 27

🌱 PR Point

  • 엄 ... 로그 String을 반환하는 것을 어떻게 어디에 두어야할지 고민하다가 해당 URLRequest의 request와 response를 로그로 찍는다는 의미에서 extension URLRequest에다가 구현해두었어요. 더 나은 방향을 아신다면 훈수부탁드림다

@Jihyun247 Jihyun247 added the enhancement New feature or request label Aug 17, 2024
@Jihyun247 Jihyun247 requested a review from devMinseok August 17, 2024 13:51
@Jihyun247 Jihyun247 self-assigned this Aug 17, 2024
Copy link

linear bot commented Aug 17, 2024

Copy link
Member

@devMinseok devMinseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!

@Jihyun247 Jihyun247 merged commit 30212ca into develop Aug 17, 2024
1 check passed
@Jihyun247 Jihyun247 deleted the feature/CAT-235 branch August 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants