Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Datadog 지원 #56

Merged
merged 5 commits into from
Sep 8, 2024
Merged

* Datadog 지원 #56

merged 5 commits into from
Sep 8, 2024

Conversation

devMinseok
Copy link
Member

관련된 문서 📄

무엇에 관한 PR 인가요? 🙋

  • Datadog SDK 추가 및 대응

어떤 것을 작업하셨나요? 🛠

  • Datadog SDK 추가
  • 민감한 정보 전부 Env.xcconfig로 이동

@devMinseok devMinseok added the enhancement New feature or request label Sep 8, 2024
@devMinseok devMinseok requested a review from Jihyun247 September 8, 2024 03:19
@devMinseok devMinseok self-assigned this Sep 8, 2024
Comment on lines +138 to +142
URLSessionInstrumentation.enable(
with: URLSessionInstrumentation.Configuration(
delegateClass: APIClientURLSessionDelegate.self,
firstPartyHostsTracing: .trace(hosts: [API.apiBaseHost])
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urlsessiondatadelegate는 왜 따로 생성해서 붙여준거야 ? ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.datadoghq.com/ko/real_user_monitoring/mobile_and_tv_monitoring/setup/ios/?tab=swiftpackagemanagerspm#initialize-the-rum-monitor-and-enable-urlsessioninstrumentation
이 문서 보면 알겠지만 URLSessionDelegate를 통해 datadog sdk에서 네트워크 요청 트래킹을 가져오는거 같아

Copy link
Member Author

@devMinseok devMinseok Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 보니까 스위즐링 해서 트래킹하는게 맞는거 같네!

URLSession 폴더에 스위즐링 하는 부분이 있어서 궁금하면 한번 봐도 좋을거 같아!

@devMinseok devMinseok merged commit e85ec21 into develop Sep 8, 2024
1 check passed
@devMinseok devMinseok deleted the feature/support-datadog branch September 8, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants