Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRUM-105] mvp2차 QA 지현 - 2 #65

Merged
merged 2 commits into from
Dec 21, 2024
Merged

[SCRUM-105] mvp2차 QA 지현 - 2 #65

merged 2 commits into from
Dec 21, 2024

Conversation

Jihyun247
Copy link
Collaborator

[SCRUM-105] FIX: mvp2차 QA 지현 - 2

어떤 것을 작업하셨나요? 🛠

  • SCRUM-96
  • SCRUM-106

🌱 PR Point

알림권한이 꺼져있을 때 알림 토글을 누르면 해당 런타임 워닝 발생 (기존 코드에서 계속 발생하던 워닝임)

An action was sent from a completed effect:

  Action:
    AppCore.Action.home(.myPage(.presented(._goToNotificationSettings)))

  Effect returned from:
    AppCore.Action.home(.myPage(.presented(.timerAlarmToggleButtonTapped)))

Avoid sending actions using the 'send' argument from 'Effect.run' after the effect has completed. This can happen if you escape the 'send' argument in an unstructured context.

To fix this, make sure that your 'run' closure does not return until you're done calling 'send'.

[MypageCore] 요부분 !

            let notificationSettingDialog = turnOnNotificationSettingDialog {
              await send(._goToNotificationSettings(.timer))
            }

제가 주말에 계속 노트북을 못볼 예정이라 ... 우선 큐에이 올라온 것은 표면적으로 마무리해놓고,
담주 월욜에 작업시간이 좀 생길 것 같아서 그 날 스트림 리스너 작업 + 해당 런타임 워닝 보겠습니닷

_goToNotificationSetting - runtime warning
@Jihyun247 Jihyun247 added the bug Something isn't working label Dec 20, 2024
@Jihyun247 Jihyun247 requested a review from devMinseok December 20, 2024 04:23
@Jihyun247 Jihyun247 self-assigned this Dec 20, 2024
@devMinseok
Copy link
Member

런타임에서 발생하는 경고 문구는 dialog를 생성해서 set 하는 action이 이미 끝났는데 dialog에서 발생한 action이 나중에 발생하는 바람에 나는 현상이네 요건 내가 dialog를 좀 손봐서 고쳐놓을게!

@devMinseok devMinseok merged commit 7a8cf0a into develop Dec 21, 2024
1 check passed
@devMinseok devMinseok deleted the feature/SCRUM-105 branch December 21, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants