feat: 미션 독려 알림 구현 #100
Merged
feat: 미션 독려 알림 구현 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimyu0218
commented
Nov 19, 2024
Comment on lines
+35
to
+42
| default long getDaysAfterMissionCompletion(final Long memberId) { | ||
| Optional<MissionMember> missionMember = findTop1ByMemberIdOrderByUpdatedAtDesc(memberId); | ||
| if (missionMember.isEmpty() || !missionMember.get().isCompleted()) { | ||
| return 0L; | ||
| } | ||
| Duration duration = Duration.between(LocalDateTime.now(), missionMember.get().getUpdatedAt()); | ||
| return duration.toDays(); | ||
| } |
There was a problem hiding this comment.
지금 사용하는 부분은 아닌데
저번 회의에서 미션 끝난 지 N일 째 같은 카운트가 있어서 만들어 봤습니당
songyi00
approved these changes
Nov 20, 2024
| public void save(String memberId, String deviceToken, long ttl) { | ||
| LocalDate pushDate = computePushDate(); | ||
| String key = makeKey(pushDate, memberId); | ||
| redisTemplate.opsForValue().set(key, deviceToken, Duration.ofMillis(ttl)); |
| missionMembers.forEach(missionMember -> { | ||
| missionMember.updateMissionStatus(mission, memberCount); | ||
| Member member = missionMember.getMember(); | ||
| if (missionMember.isCompleted() && member.getDeviceToken() != null) { |
There was a problem hiding this comment.
missionMember.member.deviceToken 이렇게 접근하면 쿼리 �N+1 문제 있을 것 같아서 벌크로 조회한 후에 매핑해주는건 어때?
추가로 만약 알림 비활성화 여부 필드 생기면 디바이스 토큰 null 체크 조건문 변경 필요하겠습니당
|
다른 PR에서 리뷰 내용 반영하도록 하겠습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #
작업 개요
(#84)
미션 완료 후 7일간 아무런 미션에 참여하지 않거나 생성하지 않은 경우, 스케줄러를 통해 독려 푸시 알림을 전송합니다.
작업 사항
MissionRetryPushJob을 만들고 15시에 실행하도록 만들었습니다. (다른 알림과 달리 언제 보내야 한다는 요구사항이 없어 15시로 작성했습니다)MissionMember의 상태가COMPLETED로 변경될 때, redis에 멤버의 디바이스 토큰을 ttl을 걸어 저장했습니다.mission_retry_message:[PUSH_DATE]:[MEMBER_ID]cancelRetryMessage를 통해 등록한 key-value쌍을 삭제합니다.고민한 점들(필수 X)
여기에 작성하세요
스크린샷(필수 X)
여기에 작성하세요