Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duration 계산, fcm 토픽 형식 오류 수정 #92

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

kimyu0218
Copy link
Collaborator

@kimyu0218 kimyu0218 commented Nov 10, 2024

Issue Number

close: #

작업 개요

  • duration 계산 오류
Unable to obtain LocalDateTime from TemporalAccessor: 2024-11-10 of type java.time.LocalDate

LocalDate에서 LocalDateTime을 얻으려고 하면서 발생

  • fcm 토픽 형식 오류
Malformed topic name

작업 사항

Duration.between 에 전달하는 2번째 매개변수 LocalDateTime으로 변경

LocalDateTime startTime = LocalDateTime.of(this.missionStartDate.toLocalDate(), LocalTime.parse(this.uploadStartTime));
- Duration duration = Duration.between(startTime, LocalDate.now());
+ Duration duration = Duration.between(startTime, LocalDateTime.now());

FCM 토픽 메시지 형식에 벗어나지 않도록 수정

- private static final String TOPIC_PREFIX = "missionId#";
+ private static final String TOPIC_PREFIX = "/topics/missionId_"

고민한 점들(필수 X)

여기에 작성하세요

스크린샷(필수 X)

여기에 작성하세요

@kimyu0218 kimyu0218 requested a review from songyi00 as a code owner November 10, 2024 15:04
Copy link
Member

@songyi00 songyi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했슈 🔥

@kimyu0218 kimyu0218 changed the title fix: duration 계산 오류 수정 fix: duration 계산, fcm 토픽 형식 오류 수정 Nov 11, 2024
@kimyu0218 kimyu0218 merged commit 58aede3 into develop Nov 11, 2024
1 check passed
@kimyu0218 kimyu0218 deleted the fix/#84-fcm-push branch November 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants