Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 오늘 미션 인증한 사람 수 세는 로직 수정 #94

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

kimyu0218
Copy link
Collaborator

Issue Number

close: #93

작업 개요

Mission Member 상태 관리가 추가되면서 레코드 변경 일자로 오늘 인증 여부를 확인할 수 없게 되었습니다.
(updated_at이 갱신되는 경우가 여러 개 - 1) 미션 상태 변경, 2) 미션 인증으로 verification_count가 추가되었을 때)

작업 사항

Mission Member 레코드 대신 Mission Verification 레코드를 사용하여 실제 인증 레코드를 바탕으로 progressCount를 계산하도록 만들었습니다.

private int getProgressCount(final Long missionId) {
    List<MissionVerification> missionVerifications = missionVerificationRepository.findAllByMissionIdAndDate(missionId, LocalDate.now());
    return missionVerifications.size();
}

고민한 점들(필수 X)

여기에 작성하세요

스크린샷(필수 X)

여기에 작성하세요

@kimyu0218 kimyu0218 requested a review from songyi00 as a code owner November 11, 2024 11:38
Copy link
Member

@songyi00 songyi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@kimyu0218 kimyu0218 merged commit df44687 into develop Nov 14, 2024
1 check passed
@kimyu0218 kimyu0218 deleted the fix/#93-mission-board branch November 14, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

오늘 인증한 멤버 수 계산
2 participants