fix: pnpm v11 build allowlist 를 pnpm-workspace.yaml 로 이전#140
Merged
Conversation
The previous fix added pnpm.onlyBuiltDependencies to package.json, but pnpm v11 only honors this configuration when it lives in pnpm-workspace.yaml, so the docker build still failed with ERR_PNPM_IGNORED_BUILDS for sharp and unrs-resolver. Moves the allowlist to pnpm-workspace.yaml, removes the now-redundant package.json field, and copies the workspace file in the client Dockerfile so it is present during pnpm install. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Comment on lines
+1
to
+3
| onlyBuiltDependencies: | ||
| - sharp | ||
| - unrs-resolver |
Contributor
There was a problem hiding this comment.
pnpm v11에서 pnpm-workspace.yaml 파일은 packages 필드를 필수로 요구합니다. 단일 패키지 프로젝트인 경우에도 아래와 같이 packages 필드를 추가하여 워크스페이스 구성을 명시해야 빌드 오류(ERR_PNPM_INVALID_WORKSPACE_CONFIGURATION)를 방지할 수 있습니다.
packages:
- "."
onlyBuiltDependencies:
- sharp
- unrs-resolver
youngminss
added a commit
that referenced
this pull request
May 7, 2026
The previous attempts (#139, #140) tried to allowlist sharp and unrs-resolver under pnpm v11's stricter ignored-builds policy, but v11 still fails the install with ERR_PNPM_IGNORED_BUILDS even when onlyBuiltDependencies is configured. Corepack picked v11.0.8 because the project never declared a packageManager field, so a single release of pnpm flipped CI from green to red. Pins pnpm to 10.13.1 (the version that produced the last green build) via packageManager so corepack resolves the same version on CI as on local dev. The pnpm-workspace.yaml allowlist is kept so a future migration to v11 stays straightforward. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
that referenced
this pull request
May 12, 2026
## [2.7.0](v2.6.0...v2.7.0) (2026-05-12) ### Features * RegionStep에 지역 요청 Banner 및 Dialog 추가 ([#133](#133)) ([b61ba13](b61ba13)) * 식당 상세 시안 정렬 및 전화하기 CTA 추가 ([#138](#138)) ([b675fc4](b675fc4)) * 식당 상세 페이지 신규 구현 ([#134](#134)) ([055841c](055841c)) * 약속 장소 섹션 캐러셀 UI 개편 ([#137](#137)) ([c77b04a](c77b04a)) ### Bug Fixes * certbot 컨테이너 제거 후 호스트 certbot 방식으로 전환 ([a104bfb](a104bfb)) * **ci:** allowlist sharp and unrs-resolver build scripts ([#139](#139)) ([6399273](6399273)) * **ci:** move pnpm build allowlist to pnpm-workspace.yaml ([#140](#140)) ([17ecd51](17ecd51)) * **ci:** pin pnpm to 10.13.1 via packageManager ([#141](#141)) ([e020a3c](e020a3c)), closes [#139](#139) [#140](#140) * **ci:** pnpm 버전 충돌 해결을 위해 워크플로우의 version 명시 제거 ([a5000af](a5000af)) ### Code Refactoring * VoteSummarySection 거리 블록 숨김 및 디렉터리 분리 ([#136](#136)) ([31f9d13](31f9d13)), closes [#132](#132)
github-actions Bot
pushed a commit
that referenced
this pull request
May 12, 2026
## [2.7.0-beta.7](v2.7.0-beta.6...v2.7.0-beta.7) (2026-05-12) ### Bug Fixes * certbot 컨테이너 제거 후 호스트 certbot 방식으로 전환 ([a104bfb](a104bfb)) * **ci:** move pnpm build allowlist to pnpm-workspace.yaml ([#140](#140)) ([17ecd51](17ecd51)) * **ci:** pin pnpm to 10.13.1 via packageManager ([#141](#141)) ([e020a3c](e020a3c)), closes [#139](#139) [#140](#140) * **ci:** pnpm 버전 충돌 해결을 위해 워크플로우의 version 명시 제거 ([a5000af](a5000af))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 PR 제목
fix: pnpm v11 build allowlist 를 pnpm-workspace.yaml 로 이전
📑 작업 상세 내역
package.json의pnpm.onlyBuiltDependencies에 화이트리스트를 추가했지만 pnpm v11 은 이 설정을pnpm-workspace.yaml에서만 인정해 docker build 가 여전히ERR_PNPM_IGNORED_BUILDS로 실패했습니다pnpm-workspace.yaml을 신규 추가하고sharp/unrs-resolver화이트리스트를 그쪽으로 이전합니다package.json의 (이제 무시되는)pnpm필드를 제거합니다docker/client/Dockerfile의COPY단계에pnpm-workspace.yaml을 추가해 install 시 워크스페이스 설정이 정상 적용되게 합니다🙏 리뷰 요청 사항
packageManager핀 검토 가치 있음 (본 PR 비범위)📃 참고 자료
pnpm-workspace.yaml권장)🖼️ 작업 결과물