Improve mouse support #31
Conversation
| @@ -1041,6 +1041,24 @@ function onCursorUp(view) | |||
| selectline_if_tree(view) | |||
| end | |||
|
|
|||
| --scroll cursor when mousewheel is scrolled | |||
| function onScrollDown(view) | |||
There was a problem hiding this comment.
This & onScrollUp should be pre instead of on. This is because a pre action is triggered before performing the action, while on means it's triggered after the action occurs.
Think of it in the sequence of actions:
- You try to scroll down, triggering the
preScrollDown, but not actually performing the action. - If
preScrollDownhasreturn falsein it, the scroll down action is canceled, stopping here. Otherwise, it continues to 3. - The scroll action is actually performed.
- The
onScrollDowncallback is triggered. This doesn't listen for anyreturn's
| end | ||
| end | ||
|
|
||
| function onScrollUp(view) |
| tree_view.Buf.Cursor:Down() | ||
| select_line() | ||
| -- not sure if return false is required, I'm new to this | ||
| return false |
There was a problem hiding this comment.
return false tells Micro to not actually perform the action, but that doesn't work if it's on.
| try_open_at_y(new_y) | ||
|
|
||
| --open item if it is selected, otherwise select it. | ||
| if tree_view.Buf.Cursor.Loc.Y == new_y then |
There was a problem hiding this comment.
Is this chunk really necessary? I feel having to double-click to open is kind of pointless, although I am used to single-click's on my linux DE.
There was a problem hiding this comment.
I personally prefer double click but it also solves the problem that if you use a mouse click to switch to the tree pane it will enter whatever directory the cursor is on
There was a problem hiding this comment.
That problem could be solved without requiring double-click, I think?
Possibly by adding in a section to the pre callbacks to check for if view ~= tree_view, getting cursor xy position, then checking if it's anywhere inside the dimensions of the tree. If it is, you could set the current view to the tree_view, then perform the scroll action.
But I'm not exactly sure how you'd get the xy of the tree. Probably possible..
|
@Tacolizard Are you still working on this? I don't mind if you leave the double-click as-is, but I can't merge if you don't make the changes to using |
|
would love to see these fixes merged. @Tacolizard are you still interested in in doing these changes? otherwise I would fix this PR by opening a new one if thats fine @sum01 ? |
|
Fine by me either way. |
|
any updates on this? |
Scrolling the mouse now scrolls the cursor instead of the entire tree.
Clicking on an unselected item will select it. Clicking a selected item will open it. (Makes it simpler to see what's going on, and makes it easier to switch between panes using the mouse)
I haven't made any plugins before so I copied a bit of existing code that I'm not sure is necessary.