Only read 'gridRequests' from /gridUpdate response#33
Open
Detharon wants to merge 1 commit intoNightdawg:masterfrom
Open
Only read 'gridRequests' from /gridUpdate response#33Detharon wants to merge 1 commit intoNightdawg:masterfrom
Detharon wants to merge 1 commit intoNightdawg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long long time ago, there used to be feature baked in the clients that allowed you to find yourself on the global, public map.
The mapper simply returned the map location in a form of (map id, x, y) and the client used it to create a link which would show you the grid you're on.
Hurricane doesn't have that feature, and probably won't since modern private maps track in a better way, but it still expects the mapper to return the map id, x, y in the response data. This is then stored on that
cacheHashMap never to be used again and this map grows over time as you travel the world.So, I suggest removing it; mappers won't have to send that useless data back and client won't be storing that ever-growing map of grids.