Remove clippy exception for result_large_err #39
Merged
+1
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint has been fixed by updating to ureq v3 so we no longer need an exception for it.
sosthene-nitrokey
requested changes
Feb 17, 2025
| @@ -1 +1 @@ | |||
| 7.10.0-SNAPSHOT | |||
There was a problem hiding this comment.
Why this change?
There was a problem hiding this comment.
I re-generated the client code to make sure that it was up to date. Not sure why it was 7.10 in the first place – even if rebuild the Docker container, update_openapi.sh uses 7.8 for me.
There was a problem hiding this comment.
Ah, it looks like you need to delete the openapitools/openapi-generator-cli base image in order to update the version. The current version would be 7.12. If we really want to approach this, we should change update_openapi.sh to update the image before generating the code. I suggest to do that in a separate PR.
|
I considered using |
sosthene-nitrokey
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint has been fixed by updating to ureq v3 so we no longer need an exception for it.