Ensure all links to udev rules file point to recent version #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The udev rules file `41-nitrokey.rules` is crucial to the devices' functioning under Linux. The canonical and maintained version of these rules seems to be the one at https://github.com/Nitrokey/nitrokey-udev-rules The documentation contained several links to older, unmaintained versions at different URLs, which are missing some recent fixes, e.g. [nitrokey-udev-rules PR Nitrokey#6](Nitrokey/nitrokey-udev-rules#6). Make sure the documentation always links to the maintained version at https://raw.githubusercontent.com/Nitrokey/nitrokey-udev-rules/main/41-nitrokey.rules
daringer
approved these changes
Jan 27, 2025
|
nice - many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The udev rules file
41-nitrokey.rulesis crucial to the devices' functioning under Linux. The canonical and maintained version of these rules seems to be the one at https://github.com/Nitrokey/nitrokey-udev-rulesThe documentation contained several links to older, unmaintained versions at different URLs, which are missing some recent fixes, e.g. nitrokey-udev-rules PR #6.
Make sure the documentation always links to the maintained version at https://raw.githubusercontent.com/Nitrokey/nitrokey-udev-rules/main/41-nitrokey.rules
The old URLs that have been replaced where:
https://raw.githubusercontent.com/Nitrokey/libnitrokey/master/data/41-nitrokey.rules
https://www.nitrokey.com/sites/default/files/41-nitrokey.rules
Now all URLs point to either https://raw.githubusercontent.com/Nitrokey/nitrokey-udev-rules/main/41-nitrokey.rules or https://raw.githubusercontent.com/Nitrokey/nitrokey-udev-rules/refs/heads/main/41-nitrokey.rules, which both lead to the same file/version.