[WIP] Clean up inconsistencies and duplicates in USB configuration #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems CCID USB headers ware redundant with CCIDHID USB ones, althougt it was not clear which were actually used (the same include guards were used). CCID_usb_conf.h values were defined as in usb_conf.h, the added CCID_EP*_OUT_Callback were not used
Correct comments that were not in sync with the current code base.
cyril-L
force-pushed
the
usb/cleanup
branch
2 times, most recently
from
617370b to
11a13b0
Compare
- Kept the descriptor content as-is, checked comments agains libusb output - Replaced some defined values with real one to be easier to compare with specs and other implementations - Aligned comments
|
Hi! Thank you for the PR! Indeed this looks like a big cleanup. |
cyril-L
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is certainly more cleanup to do, but I found those the more confusing.