Change testTarget -> testTargets #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
sternenseemann
approved these changes
Feb 10, 2025
| @@ -123,7 +123,7 @@ hooks = | |||
| , ("hlibgit2 >= 0.18.0.14", set (testDepends . tool . contains (pkg "git")) True) | |||
| , ("hmatrix < 0.18.1.1", set phaseOverrides "preConfigure = \"sed -i hmatrix.cabal -e '/\\\\/usr\\\\//D'\";") | |||
| , ("holy-project", set doCheck False) -- attempts to access the network | |||
| , ("hoogle", set testTarget "--test-option=--no-net") | |||
| , ("hoogle", set testTargets ["--test-option=--no-net"]) | |||
There was a problem hiding this comment.
This should be testFlags instead, but I suspect cabal2nix doesn't know about it yet. Maybe something to take care of in a follow up change / #504.
sternenseemann
force-pushed
the
wip/teo/testTargets
branch
from
0da0e01 to
8d28da6
Compare
We refactor testTarget from an unstructured string, to a list of strings representing testTargets. See the corresponding nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/306283/files Co-authored-by: sternenseemann <[email protected]>
sternenseemann
force-pushed
the
wip/teo/testTargets
branch
from
8d28da6 to
a28d127
Compare
|
Result (zero rebuilds!): diff --git a/pkgs/development/haskell-modules/hackage-packages.nix b/pkgs/development/haskell-modules/hackage-packages.nix
index bd0fb7354264..503a37fe3a30 100644
--- a/pkgs/development/haskell-modules/hackage-packages.nix
+++ b/pkgs/development/haskell-modules/hackage-packages.nix
@@ -92690,7 +92690,7 @@ self: {
];
testToolDepends = [ hspec-discover ];
doHaddock = false;
- testTarget = "spec";
+ testTargets = [ "spec" ];
description = "DNS library in Haskell";
license = lib.licenses.bsd3;
}) {};
@@ -157039,7 +157039,7 @@ self: {
wai wai-logger warp warp-tls zlib
];
executableHaskellDepends = [ base ];
- testTarget = "--test-option=--no-net";
+ testTargets = [ "--test-option=--no-net" ];
description = "Haskell API Search";
license = lib.licenses.bsd3;
mainProgram = "hoogle";
@@ -163560,7 +163560,7 @@ self: {
transformers
];
testToolDepends = [ hspec-meta ];
- testTarget = "--test-option=--skip --test-option='Test.Hspec.Core.Runner.hspecResult runs specs in parallel'";
+ testTargets = [ "--test-option=--skip" "--test-option='Test.Hspec.Core.Runner.hspecResult runs specs in parallel'" ];
description = "A Testing Framework for Haskell";
license = lib.licenses.mit;
hydraPlatforms = lib.platforms.none;
@@ -163589,7 +163589,7 @@ self: {
temporary tf-random time transformers
];
testToolDepends = [ hspec-meta ];
- testTarget = "--test-option=--skip --test-option='Test.Hspec.Core.Runner.hspecResult runs specs in parallel'";
+ testTargets = [ "--test-option=--skip" "--test-option='Test.Hspec.Core.Runner.hspecResult runs specs in parallel'" ];
description = "A Testing Framework for Haskell";
license = lib.licenses.mit;
}) {}; |
|
Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
|
Disregard the comment above, I was looking at the wrong PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refactor testTarget from an unstructured string, to a list of strings representing testTargets.
See the corresponding nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/306283/files