feat: Use short revision from git #1548
Open
+43
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could short shas not become invalid over time because they are no longer "long" enough to be displayed by GitHub? |
Member
Author
|
Damn. |
Member
|
Though I don't expect it would happen so commonly. |
Member
Author
|
Think I found a solution. We just store the hash length we have seen for each URI and select the longest one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually already ask git for the short revision, so we might as well persist it to DB and render it on the frontend. To persist it, this change includes a database migraton. For older jobsetevals, we fall back on truncating the revision on 12 characters.
This logic should allow nixpkgs to scale to an infinite number of commits without any more Hydra adjustments.
Closes #1245