nit: add missing diskSelector to node_filesystem_files_free
#550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfly
changed the title
diskSelector to `node_filesystem_files_freediskSelector to node_filesystem_files_free
IIUC, this doesn't change the behavior of this query at all (Prometheus
will still only pick values for `node_filesystem_files_free` and
`node_filesystem_files` where all the labels match), but perhaps
makes it cleaner to read.
I'm extremely new to PromQL, and I'm mostly filing this as a learning
opportunity. Are there best practices around this sort of thing? Do we
like the way this was written, and should I change our other expressions
ot match (some of the other expressions use `${diskSelector}` twice).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC, this doesn't change the behavior of this query at all (Prometheus will still only pick values for
node_filesystem_files_freeandnode_filesystem_fileswhere all the labels match), but perhaps makes it cleaner to read.I'm extremely new to PromQL, and I'm mostly filing this as a learning opportunity. Are there best practices around this sort of thing? Do we like the way this was written, and should I change our other expressions ot match (some of the other expressions use
${diskSelector}twice).