feat: add standalone GitHub Action for installing Nix #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroche
force-pushed
the
action/init
branch
9 times, most recently
from
d07c150 to
ba78b94
Compare
Replace DeterminateSystems/nix-installer-action with a standalone implementation that makes it easy for anyone to install Nix in their GitHub Actions workflows. Tested successfully with act using v3.11.3 release.
Previously, the --add-channel flag used SetFalse which was confusing: - Passing the flag would DISABLE channels - Default was to enable channels Now it uses SetTrue which is intuitive: - Passing --add-channel ENABLES channels - Default is to disable channels (no unnecessary channel updates)
jfroche
force-pushed
the
action/init
branch
2 times, most recently
from
37d9332 to
58308d4
Compare
The installer was using dirs::home_dir() which reads the $HOME environment variable. On macOS, sudo preserves the original user's HOME by default (unlike Linux which resets it to /root), causing channels to be created in /Users/runner/.nix-channels. The fix uses nix::unistd::User to look up root's actual home directory from /etc/passwd, which is: - /var/root on macOS - /root on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace DeterminateSystems/nix-installer-action with a standalone implementation that makes it easy for anyone to install Nix in their GitHub Actions workflows.