Move section on indented strings after string interpolation #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing to move the "_Indented strings_" section after "_String interpolation_" because I think it fits better there logically. Also added a note that string interpolation works in indented strings as well.
fricklerhandwerk
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Hey @toraritte, sorry for the long delay; nix.dev has been at low priority for me in the past months, which is why I didn't manage to address PRs that required me to think a bit harder than usual.
I wasn't sure I agree with the change, but having finally given it a few minutes of focus time I think it's good. It was also a good opportunity to complete a TODO note.
Thanks a lot for putting in the effort! :)
fricklerhandwerk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to move the "Indented strings" section after "String interpolation" because I think it fits better there logically. Also added a note that string interpolation works in indented strings as well.