Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up tests/functional/flakes/flakes.sh #11926

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

edolstra
Copy link
Member

Motivation

This test was very big (800+ lines) and slow, so let's split it into smaller bits.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Nov 20, 2024
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thought it does look like there is a test failure.

@edolstra edolstra merged commit b767987 into NixOS:master Nov 20, 2024
11 checks passed
@edolstra edolstra deleted the split-flake-tests branch November 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants