Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to symlink headers to old location #12817

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 31, 2025

See comments on the script; this is supposed to avoid breaking muscle memory without complicating the build system (which proved harder than I thought too) or not doing the header hygiene change at all.

link-headers: use pathlib consistenly and fix type errors

Depends on #12764

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority store Issues and pull requests concerning the Nix store repl The Read Eval Print Loop, "nix repl" command and debugger fetching Networking with the outside (non-Nix) world, input locking c api Nix as a C library with a stable interface labels Mar 31, 2025
@Mic92 Mic92 force-pushed the link-header-script branch 5 times, most recently from 7b05ada to 2bd37c4 Compare March 31, 2025 16:43
Copy link

dpulls bot commented Mar 31, 2025

🎉 All dependencies have been resolved !

@Mic92 Mic92 force-pushed the link-header-script branch from 2bd37c4 to 84ec6fa Compare March 31, 2025 18:05
@Ericson2314 Ericson2314 added the backport 2.28-maintenance Automatically creates a PR against the branch label Mar 31, 2025
@Mic92 Mic92 force-pushed the link-header-script branch from 84ec6fa to f41a035 Compare March 31, 2025 19:25
See comments on the script; this is supposed to avoid breaking muscle
memory without complicating the build system (which proved harder than I
thought too) or not doing the header hygiene change at all.

link-headers: use pathlib consistenly and fix type errors
@Mic92 Mic92 force-pushed the link-header-script branch from f41a035 to c6a176b Compare March 31, 2025 19:32
@Mic92 Mic92 merged commit 0e1da29 into master Mar 31, 2025
25 checks passed
@Mic92 Mic92 deleted the link-header-script branch March 31, 2025 22:48
mergify bot added a commit that referenced this pull request Mar 31, 2025
…2817

Create script to symlink headers to old location (backport #12817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.28-maintenance Automatically creates a PR against the branch c api Nix as a C library with a stable interface documentation fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command repl The Read Eval Print Loop, "nix repl" command and debugger store Issues and pull requests concerning the Nix store with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants