-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
don't include derivation name in temporary build directories #13839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the migration to /nix/var/nix/builds we now have failing builds when the derivation name is too long. This change removes the derivation name from the temporary build to have a predictable prefix length: Also see: NixOS/infra#764 for context.
|
I would like to backport this to nix 2.30/2.31, so that we can also upgrade hydra. |
|
@Mic92, is this actually enough savings to make Darwin builds not fail? We can do a bit more drastic savings to err on the safe side. See Emily's patches to Lix for other options. I imagine we can also rename |
I think it its. Names should be now shorter than previously with /tmp. |
|
Also just found out that lix is doing similar things now: https://git.lix.systems/lix-project/lix/commit/ce6dcf18d6e5b0a50bcc0059bd18867d8ac9f8da |
|
Backporting because this will be required the nix upgrade. |
…3839 don't include derivation name in temporary build directories (backport #13839)
…3839 don't include derivation name in temporary build directories (backport #13839)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
With the migration to /nix/var/nix/builds we now have failing builds when the derivation name is too long.
This change removes the derivation name from the temporary build to have a predictable prefix length:
Also see: NixOS/infra#764
for context.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.