Skip to content

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 27, 2025

With the migration to /nix/var/nix/builds we now have failing builds when the derivation name is too long.
This change removes the derivation name from the temporary build to have a predictable prefix length:

Also see: NixOS/infra#764
for context.

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

With the migration to /nix/var/nix/builds we now have failing builds
when the derivation name is too long.
This change removes the derivation name from the temporary build to have
a predictable prefix length:

Also see: NixOS/infra#764
for context.
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Aug 27, 2025
@Mic92
Copy link
Member Author

Mic92 commented Aug 27, 2025

I would like to backport this to nix 2.30/2.31, so that we can also upgrade hydra.

@xokdvium
Copy link
Contributor

@Mic92, is this actually enough savings to make Darwin builds not fail? We can do a bit more drastic savings to err on the safe side. See Emily's patches to Lix for other options. I imagine we can also rename var/builds to var/b

@Mic92
Copy link
Member Author

Mic92 commented Aug 27, 2025

@Mic92, is this actually enough savings to make Darwin builds not fail? We can do a bit more drastic savings to err on the safe side. See Emily's patches to Lix for other options. I imagine we can also rename var/builds to var/b

I think it its. Names should be now shorter than previously with /tmp.

@Mic92
Copy link
Member Author

Mic92 commented Aug 27, 2025

Also just found out that lix is doing similar things now: https://git.lix.systems/lix-project/lix/commit/ce6dcf18d6e5b0a50bcc0059bd18867d8ac9f8da

@Ericson2314 Ericson2314 merged commit 7b22cd5 into NixOS:master Sep 3, 2025
14 checks passed
@Mic92 Mic92 deleted the infra branch September 3, 2025 21:15
@Mic92 Mic92 added backport 2.30-maintenance Automatically creates a PR against the branch backport 2.31-maintenance Automatically creates a PR against the branch labels Sep 16, 2025
@Mic92
Copy link
Member Author

Mic92 commented Sep 16, 2025

Backporting because this will be required the nix upgrade.

mergify bot added a commit that referenced this pull request Sep 16, 2025
…3839

don't include derivation name in temporary build directories (backport #13839)
Mic92 added a commit that referenced this pull request Sep 16, 2025
…3839

don't include derivation name in temporary build directories (backport #13839)
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-2-32-0-released/70528/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.30-maintenance Automatically creates a PR against the branch backport 2.31-maintenance Automatically creates a PR against the branch documentation with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants