Get rid of real store paths in docs/tests #14923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlikely to do so (for the diff from 3.14.0 to 3.15.0)
github-actions
bot
added
documentation
new-cli
Contributor
|
Sounds good. It can also make the source unfetchable if we end up something that's also in the build closure. Though maybe squash the later invalidation commits? Not sure it makes sense to keep those separate. |
xokdvium
approved these changes
Jan 6, 2026
edolstra
force-pushed
the
remove-store-hashes
branch
from
2f02d9c to
05df7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using real store paths can result in accidental runtime dependencies if the store path occurs in the input closure. (E.g. we had an example in the
nix psmanpage causing a runtime dependency on gcc.) So let's just get rid of all of them. The script./maintainers/invalidate-store-paths.shcan be run periodically to detect/fix them.Cherry-picked from DeterminateSystems#306 and DeterminateSystems#307.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.