Factor out NarCache from RemoteFSAccessor
#15040
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ``` git show --color-moved --patience --color-moved-ws=ignore-all-space ``` to review and see that this is mostly code motion. Co-Authored-By: John Ericson <John.Ericson@Obsidian.Systems>
We had a minor combinatorial explosion of ways to do things. We can get rid of those by just having the caller call `parseNarListing` intead.
github-actions
bot
added
new-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an alternative to #14997
Context
Both commits are pure refactors. No behavior is changed by this pull request.
It doesn't quite do everything that will be needed for the feature that @edolstra is trying to implement: In particular,
NarCache, just likeRemoteFSAccessor, will use an unbounded amount of memory. But I will fix that next. I just wanted to PR this first to get the easy parts / code motion out of the way.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.