Repository navigation
Conversation
9796ebd ("Add `--process-ops` flag to `nix-daemon`") folded the condition for forwarding a --stdio connection into processOps without negating it. Since then, `nix-daemon --stdio --force-untrusted` forwards the connection to the next store, so the client is never treated as untrusted. A plain `nix-daemon --stdio` processes the ops itself instead of forwarding them, which made --process-ops a no-op. Only process the ops when the client is forced untrusted or `--process-ops` is passed.
github-actions
Bot
added
new-cli
xokdvium
reviewed
Oct 18, 2026
Comment on lines
+29
to
+31
| prog=$(readlink -e ./nix-daemon-untrusting.sh) | ||
| nix --store "ssh-ng://localhost?remote-program=$prog&remote-store=daemon" store info --json \ | ||
| | jq -e '.trusted == false' |
Contributor
There was a problem hiding this comment.
Should this test be in build-remote-.... where all existing trust override tests are?
Contributor
There was a problem hiding this comment.
We should add store info calls there to make sure that the trust relation there holds.
Contributor
There was a problem hiding this comment.
Ah I guess it's fine to keep here, although we should probably just have a separate test for this testing all the various combinations.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
9796ebd ("Add
--process-opsflag tonix-daemon") folded the condition for forwarding a --stdio connection into processOps without negating it. Since then,nix-daemon --stdio --force-untrustedforwards the connection to the next store, so the client is never treated as untrusted. A plainnix-daemon --stdioprocesses the ops itself instead of forwarding them, which made --process-ops a no-op.We therefore need to only process the ops when the client is forced untrusted or --process-ops is passed.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.