Pine64 PinePhone Pro #1073
Draft
Pine64 PinePhone Pro #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 12, 2024
| { stdenv, pkgs, ... }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "pine64-alsa-ucm"; |
There was a problem hiding this comment.
Nixpkgs maintainer are a bit uneasy to have all these kernel forks in nixpkgs, but I think it would be fine to have this package and the firmware also being part of nixpkgs.
Mic92
reviewed
Aug 12, 2024
add all directly nessesairy modules
| inherit pver upstream_patch; | ||
| src = src_pine64; | ||
| }; | ||
| features = { }; |
There was a problem hiding this comment.
This line confuses me. features is empty by default and is not passed in on line 27 of pine64/pinephone-pro/default.nix. args.argsOverride comes later, so will override this. Could you explain what this line does?
There was a problem hiding this comment.
you are right. i was testing some features and forgot to completely remove it, as it is not present in my current development branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds initial support for the PinePhone Pro using the Pine64 kernel, patched to upstream patch-version.
The current state is as follows:
panfrostsometimes crashesbrcmfmacerrors sporadically, function is not affected thanks to a partially working workaroundeg25-manager)pipewirewireplumbercrashing due to faulty camera driverspulseaudiodisplays a sink device but doesn't play audioI don't know how much time i can spend on it in the next weeks, but if someone wants to give me some feedback on what changes should be done it will be appreciated.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input