Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dell Precision 5520 (based on 5530) #1398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Dell Precision 5520 (based on 5530) #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions dell/precision/5520/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{ lib, config, ... }:

{
imports = [
../../../common/pc/laptop
../../../common/pc/laptop/ssd
../../../common/gpu/nvidia/maxwell
../../../common/gpu/nvidia/prime.nix
../../../common/cpu/intel/kaby-lake
];

boot = {
kernelParams = [
# fix lspci hanging with nouveau
# source https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1803179/comments/149
"acpi_rev_override=1"
"acpi_osi=Linux"
"nouveau.modeset=0"
"pcie_aspm=force"
"drm.vblankoffdelay=1"
"nouveau.runpm=0"
"mem_sleep_default=deep"
# fix flicker
# source https://wiki.archlinux.org/index.php/Intel_graphics#Screen_flickering
"i915.enable_psr=0"
"nvidia_drm.modeset=1"
];
};

hardware = {
nvidia = {
open = lib.mkDefault false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik we do set this in nvidia generation specific profiles i.e. ../../../common/gpu/nvidia/maxwell

nvidiaSettings = lib.mkDefault true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be already the default: https://search.nixos.org/options?channel=24.11&show=hardware.nvidia.nvidiaSettings&from=0&size=50&sort=relevance&type=packages&query=nvidiaSettings

modesetting.enable = lib.mkDefault true;
package = lib.mkDefault config.boot.kernelPackages.nvidiaPackages.stable;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not the default?

prime = {
intelBusId = lib.mkDefault "PCI:0:2:0";
nvidiaBusId = lib.mkDefault "PCI:1:0:0";
};
};
};
# This will save you money and possibly your life!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is in the wrong line.

services = {
fwupd.enable = lib.mkDefault true;
thermald.enable = lib.mkDefault true;
};
}
1 change: 1 addition & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
dell-poweredge-r7515 = import ./dell/poweredge/r7515;
dell-precision-3541 = import ./dell/precision/3541;
dell-precision-5490 = import ./dell/precision/5490;
dell-precision-5520 = import ./dell/precision/5520;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this model to the README.md table. Otherwise our CI doesn't test this.

dell-precision-5530 = import ./dell/precision/5530;
dell-precision-5560 = import ./dell/precision/5560;
dell-precision-7520 = import ./dell/precision/7520;
Expand Down