Skip to content

Commit

Permalink
digikam, kphotoalbum, photoqt: patches fixing build against exiv2 0.28.1
Browse files Browse the repository at this point in the history
  • Loading branch information
6t8k committed Nov 10, 2023
1 parent 3940405 commit dd14fdd
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 2 deletions.
10 changes: 9 additions & 1 deletion pkgs/applications/graphics/digikam/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ mkDerivation, config, lib, fetchurl, cmake, doxygen, extra-cmake-modules, wrapGAppsHook
{ mkDerivation, config, lib, fetchpatch, fetchurl, cmake, doxygen, extra-cmake-modules, wrapGAppsHook

# For `digitaglinktree`
, perl, sqlite
Expand Down Expand Up @@ -67,6 +67,14 @@ mkDerivation rec {
hash = "sha256-BQPANORF/0JPGKZxXAp6eb5KXgyCs+vEYaIc7DdFpbM=";
};

# Fix build against exiv2 0.28.1
patches = [
(fetchpatch {
url = "https://invent.kde.org/graphics/digikam/-/commit/f5ea91a7f6c1926815ec68f3e0176d6c15b83051.patch";
hash = "sha256-5g2NaKKNKVfgW3dTO/IP/H/nZ0YAIOmdPAumy3NEaNg=";
})
];

nativeBuildInputs = [
cmake
doxygen
Expand Down
9 changes: 9 additions & 0 deletions pkgs/applications/graphics/kphotoalbum/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{ mkDerivation
, fetchpatch
, fetchurl
, lib
, extra-cmake-modules
Expand All @@ -25,6 +26,14 @@ mkDerivation rec {
hash = "sha256-NWtOIHJXtc8PlltYbbp2YwDf/3QI3MdHNDX7WVQMig4=";
};

# Fix build against exiv2 0.28.1
patches = [
(fetchpatch {
url = "https://invent.kde.org/graphics/kphotoalbum/-/commit/1ceb1ae37f3f95aa290b0846969af4b26f616760.patch";
hash = "sha256-SfBJHyJZcysvemc/F09GPczBjcofxGomgjJ814PSU+c=";
})
];

# not sure if we really need phonon when we have vlc, but on KDE it's bound to
# be on the system anyway, so there is no real harm including it
buildInputs = [ exiv2 phonon libvlc ];
Expand Down
7 changes: 6 additions & 1 deletion pkgs/applications/graphics/photoqt/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ stdenv.mkDerivation rec {
hash = "sha256-kVf9+zI9rtEMmS0N4qrN673T/1fnqfcV3hQPnMXMLas=";
};

postPatch = ''
# exiv2 0.28.1
substituteInPlace CMakeLists.txt \
--replace "exiv2lib" "exiv2"
''
# error: no member named 'setlocale' in namespace 'std'; did you mean simply 'setlocale'?
postPatch = lib.optionalString stdenv.isDarwin ''
+ lib.optionalString stdenv.isDarwin ''
substituteInPlace cplusplus/main.cpp \
--replace "std::setlocale" "setlocale"
'';
Expand Down

0 comments on commit dd14fdd

Please sign in to comment.