Skip to content

Comments

rustc: allow building for musl targets#105314

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
lopsided98:rustc-musl-target
Nov 29, 2020
Merged

rustc: allow building for musl targets#105314
Ericson2314 merged 1 commit intoNixOS:masterfrom
lopsided98:rustc-musl-target

Conversation

@lopsided98
Copy link
Contributor

Motivation for this change

Makes pkgsCross.<platform>.pkgsStatic.buildPackages.rustc work.

It might be worthwhile to add similar things for hostPlatform or even buildPlatform, but this would require a lot more building to test so I haven't tried it yet.

I have tested this with a modified version of @joprice's rust-nix-test. @joprice I know this doesn't solve your problem, but it is a step in the general direction.

cc @Ericson2314

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 29, 2020
@lopsided98
Copy link
Contributor Author

@ofborg build pkgsCross.armv7l-hf-multiplatform.pkgsStatic.buildPackages.rustc

@Ericson2314 Ericson2314 merged commit 5d75fe4 into NixOS:master Nov 29, 2020
@lopsided98 lopsided98 deleted the rustc-musl-target branch November 29, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants